Skip to content

Load graph reference from pkg copy of plot schema#614

Closed
etpinard wants to merge 1 commit into
masterfrom
bye-bye-schema-get-on-import
Closed

Load graph reference from pkg copy of plot schema#614
etpinard wants to merge 1 commit into
masterfrom
bye-bye-schema-get-on-import

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

fixes #613

- instead of making a request to plot.ly to
  grab the most up-to-date schema
@etpinard

Copy link
Copy Markdown
Contributor Author

PROS

CONS

  • plotly.plotly (i.e. users making graph via plot.ly) won't be relying in the correct plot schema for key validation. For example, if we add an attribute to plotly.js and then to plot.ly, plotly.plotly users trying to user this attribute will get a validation error until we bump the default-schema.json during plotly.offline plotly.js version bumps.

I personally think the item under CONS isn't a big deal because:

  • We should update the plotly.offline plotly.js frequently
  • If a user really want to use bleeding edge keys, they can always turn off validation

@etpinard

Copy link
Copy Markdown
Contributor Author

@Kully Kully mentioned this pull request Nov 21, 2016
@theengineear

Copy link
Copy Markdown
Contributor

@etpinard I'm shifting things around wrt our api for a large-ish release. I like the idea of no longer auto-downloading the plot-schema. We have a very simple way to update the plot schema and can just do that with minor version bumps if desired.

@chriddyp and @Kully, ya'll OK with stopping the auto-download of plot-schema as well?

@chriddyp

chriddyp commented Jan 2, 2017

Copy link
Copy Markdown
Member

I'm OK with it!

@theengineear theengineear mentioned this pull request Jan 5, 2017
@theengineear

Copy link
Copy Markdown
Contributor

The ideas from this have been implemented. Closing.

@theengineear
theengineear deleted the bye-bye-schema-get-on-import branch February 2, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downloading malformed plot-schema.json can cause import plotly to break

3 participants